netdev - Re: [PATCH] net: switchdev: switchdev_handle_fdb_del_to_device(): fix no-op function for disabled CONFIG_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d272c17-ba53-6b84-5fb5-9bce6e6e7f68@pengutronix.de>
Date:   Wed, 21 Jul 2021 12:18:10 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     netdev@...r.kernel.org
Cc:     Vladimir Oltean <vladimir.oltean@....com>, kernel@...gutronix.de
Subject: Re: [PATCH] net: switchdev: switchdev_handle_fdb_del_to_device(): fix
 no-op function for disabled CONFIG_NET_SWITCHDEV

Hello,

On 7/21/21 12:15 PM, Marc Kleine-Budde wrote:
> In patch 8ca07176ab00 ("net: switchdev: introduce a fanout helper for
> SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE") new functionality including static
> inline no-op functions if CONFIG_NET_SWITCHDEV is disabled was added.
> 
> This patch fixes the following build error for disabled
> CONFIG_NET_SWITCHDEV:
> 
> | In file included from include/net/dsa.h:23,
> |                  from net/core/flow_dissector.c:8:
> | include/net/switchdev.h:410:1: error: expected identifier or ‘(’ before ‘{’ token
> |   410 | {
> |       | ^
> | include/net/switchdev.h:399:1: warning: ‘switchdev_handle_fdb_del_to_device’ declared ‘static’ but never defined [-Wunused-function]
> |   399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
> |       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 8ca07176ab00 ("net: switchdev: introduce a fanout helper for SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE")
> Cc: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>

This patch is for net-next, I've send a v2 with a corrected subject.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)