netdev - Re: [PATCH net-next v2] net: switchdev: switchdev_handle_fdb_del_to_device(): fix no-op function for disabled CONFIG_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210721102924.ejzv3lxwbltx2wr2@skbuf>
Date:   Wed, 21 Jul 2021 10:29:25 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH net-next v2] net: switchdev:
 switchdev_handle_fdb_del_to_device(): fix no-op function for disabled
 CONFIG_NET_SWITCHDEV

Hi Marc,

On Wed, Jul 21, 2021 at 12:17:14PM +0200, Marc Kleine-Budde wrote:
> In patch 8ca07176ab00 ("net: switchdev: introduce a fanout helper for
> SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE") new functionality including static
> inline no-op functions if CONFIG_NET_SWITCHDEV is disabled was added.
> 
> This patch fixes the following build error for disabled
> CONFIG_NET_SWITCHDEV:
> 
> | In file included from include/net/dsa.h:23,
> |                  from net/core/flow_dissector.c:8:
> | include/net/switchdev.h:410:1: error: expected identifier or ‘(’ before ‘{’ token
> |   410 | {
> |       | ^
> | include/net/switchdev.h:399:1: warning: ‘switchdev_handle_fdb_del_to_device’ declared ‘static’ but never defined [-Wunused-function]
> |   399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
> |       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 8ca07176ab00 ("net: switchdev: introduce a fanout helper for SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE")
> Cc: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> ---

Thank you for the patch and sorry for the breakage, I've been waiting
for my version to get accepted since yesterday:
https://patchwork.kernel.org/project/netdevbpf/patch/20210720173557.999534-2-vladimir.oltean@nxp.com/