lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 22 Jul 2021 13:45:28 +0100 (IST)
From:   Alan Maguire <alan.maguire@...cle.com>
To:     Jiri Olsa <jolsa@...hat.com>
cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Alan Maguire <alan.maguire@...cle.com>
Subject: Re: [PATCH bpf-next 0/3] libbpf: Export bpf_program__attach_kprobe_opts
 function


On Wed, 21 Jul 2021, Jiri Olsa wrote:

> hi,
> making bpf_program__attach_kprobe_opts function exported,
> and other fixes suggested by Andrii in recent review [1][2].
>

Looks great! Feel free to add 

Reviewed-by: Alan Maguire <alan.maguire@...cle.com>
Tested-by: Alan Maguire <alan.maguire@...cle.com>

> thanks,
> jirka
> 
> 
> [1] https://lore.kernel.org/bpf/CAEf4BzYELMgTv_RhW7qWNgOYc_mCyh8-VX0FUYabi_TU3OiGKw@mail.gmail.com/
> [2] https://lore.kernel.org/bpf/CAEf4Bzbk-nyenpc86jtEShset_ZSkapvpy3fG2gYKZEOY7uAQg@mail.gmail.com/
> 
> ---
> Jiri Olsa (3):
>       libbpf: Fix func leak in attach_kprobe
>       libbpf: Allow decimal offset for kprobes
>       libbpf: Export bpf_program__attach_kprobe_opts function
> 
>  tools/lib/bpf/libbpf.c                                    | 34 +++++++++++++++++++---------------
>  tools/lib/bpf/libbpf.h                                    | 14 ++++++++++++++
>  tools/lib/bpf/libbpf.map                                  |  1 +
>  tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c |  2 ++
>  tools/testing/selftests/bpf/progs/get_func_ip_test.c      | 11 +++++++++++
>  5 files changed, 47 insertions(+), 15 deletions(-)
> 
> 

Powered by blists - more mailing lists