lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 22 Jul 2021 21:57:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Simon Horman <simon.horman@...igine.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...lanox.com>, oss-drivers@...igine.com,
        Baowen Zheng <baowen.zheng@...igine.com>,
        Louis Peens <louis.peens@...igine.com>,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH net-next 1/3] flow_offload: allow user to offload tc
 action to net device

Hi Simon,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Simon-Horman/flow_offload-hardware-offload-of-TC-actions/20210722-172229
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c2255ff47768c94a0ebc3968f007928bb47ea43b
config: microblaze-randconfig-r011-20210722 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9228a8efdbf7a736354b87c0db3260dd7d2c4abd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Simon-Horman/flow_offload-hardware-offload-of-TC-actions/20210722-172229
        git checkout 9228a8efdbf7a736354b87c0db3260dd7d2c4abd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/sched/act_api.c:1064:5: warning: no previous prototype for 'tcf_action_offload_cmd' [-Wmissing-prototypes]
    1064 | int tcf_action_offload_cmd(struct tc_action *actions[],
         |     ^~~~~~~~~~~~~~~~~~~~~~


vim +/tcf_action_offload_cmd +1064 net/sched/act_api.c

  1062	
  1063	/* offload the tc command after inserted */
> 1064	int tcf_action_offload_cmd(struct tc_action *actions[],
  1065				   struct netlink_ext_ack *extack)
  1066	{
  1067		struct flow_offload_action *fl_act;
  1068		int err = 0;
  1069	
  1070		fl_act = flow_action_alloc(tcf_act_num_actions(actions));
  1071		if (!fl_act)
  1072			return -ENOMEM;
  1073	
  1074		fl_act->extack = extack;
  1075		err = tc_setup_action(&fl_act->action, actions);
  1076		if (err) {
  1077			NL_SET_ERR_MSG_MOD(extack,
  1078					   "Failed to setup tc actions for offload\n");
  1079			goto err_out;
  1080		}
  1081		fl_act->command = FLOW_ACT_REPLACE;
  1082	
  1083		flow_indr_dev_setup_offload(NULL, NULL, TC_SETUP_ACT, fl_act, NULL, NULL);
  1084	
  1085		tc_cleanup_flow_action(&fl_act->action);
  1086	
  1087	err_out:
  1088		kfree(fl_act);
  1089		return err;
  1090	}
  1091	EXPORT_SYMBOL(tcf_action_offload_cmd);
  1092	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (39738 bytes)

Powered by blists - more mailing lists