netdev - Re: [PATCH] wwan: core: Fix missing RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHNKnsS1yQq9vbuLaa0XuKQ2PEmsw--tx-Fb8sEpzUmiybzuRA@mail.gmail.com>
Date:   Thu, 22 Jul 2021 19:14:21 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     David Miller <davem@...emloft.net>,
        Johannes Berg <johannes@...solutions.net>,
        netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] wwan: core: Fix missing RTM_NEWLINK event

Hello Loic,

On Thu, Jul 22, 2021 at 6:39 PM Loic Poulain <loic.poulain@...aro.org> wrote:
> By default there is no rtnetlink event generated when registering a
> netdev with rtnl_link_ops until its rtnl_link_state is switched to
> initialized (RTNL_LINK_INITIALIZED). This causes issues with user
> tools like NetworkManager which relies on such event to manage links.
>
> Fix that by setting link to initialized (via rtnl_configure_link).

Shouldn't the __rtnl_newlink() function call rtnl_configure_link()
just after the newlink() callback invocation? Or I missed something?

-- 
Sergey