lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jul 2021 08:22:15 +0300 From: Sasha Neftin <sasha.neftin@...el.com> To: Andrew Lunn <andrew@...n.ch> CC: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>, <vitaly.lifshits@...el.com>, Dvora Fuxbrumer <dvorax.fuxbrumer@...ux.intel.com> Subject: Re: [PATCH net-next 09/12] igc: Remove _I_PHY_ID checking On 7/21/2021 22:53, Andrew Lunn wrote: > On Wed, Jul 21, 2021 at 09:02:13PM +0300, Sasha Neftin wrote: >> On 7/21/2021 17:50, Andrew Lunn wrote: >>> On Tue, Jul 20, 2021 at 04:20:58PM -0700, Tony Nguyen wrote: >>>> From: Sasha Neftin <sasha.neftin@...el.com> >>>> >>>> i225 devices have only one PHY vendor. There is no point checking >>>> _I_PHY_ID during the link establishment and auto-negotiation process. >>>> This patch comes to clean up these pointless checkings. >>> >>> I don't know this hardware.... >>> >>> Is the PHY integrated into the MAC? Or is it external? >> i225 controller offers a fully-integrated Media Access Control >> (MAC) and Physical Layer (PHY) port. >> Both components (MAC and PHY) supports 2.5G > > Hi Sasha > > Thanks for the info. Then this change make sense. But the commit > message could of been better. It is not really about there being one > PHY vendor, it is simply impossible for the PHY to be anything else, > so there is no need to check. We will clarify it in the commit message. > > Andrew > Sasha Neftin
Powered by blists - more mailing lists