netdev - Re: [PATCH iproute2] ip/tunnel: always print all known attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210722151132.4384026a@hermes.local>
Date:   Thu, 22 Jul 2021 15:11:32 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Ilya Dmitrichenko <errordeveloper@...il.com>
Cc:     netdev@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH iproute2] ip/tunnel: always print all known attributes

On Fri, 16 Jul 2021 16:35:57 +0100
Ilya Dmitrichenko <errordeveloper@...il.com> wrote:

> Presently, if a Geneve or VXLAN interface was created with 'external',
> it's not possible for a user to determine e.g. the value of 'dstport'
> after creation. This change fixes that by avoiding early returns.
> 
> This change partly reverts 00ff4b8e31af ("ip/tunnel: Be consistent when
> printing tunnel collect metadata").
> 
> Signed-off-by: Ilya Dmitrichenko <errordeveloper@...il.com>

The patch looks fine, but it doesn't patch checkpatch.
Please fix your editor settings to do whitespace properly.

~/git/iproute2 $ ~/Src/kernel/linux/scripts/checkpatch.pl ~/Downloads/iproute2-ip-tunnel-always-print-all-known-attributes.patch 
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 00ff4b8e31af ("ip/tunnel: Be consistent when printing tunnel collect metadata")'
#88: 
This change partly reverts 00ff4b8e31af ("ip/tunnel: Be consistent when

ERROR: code indent should use tabs where possible
#129: FILE: ip/iplink_geneve.c:259:
+        }$

WARNING: please, no spaces at the start of a line
#129: FILE: ip/iplink_geneve.c:259:
+        }$

ERROR: code indent should use tabs where possible
#161: FILE: ip/iplink_vxlan.c:426:
+        }$

WARNING: please, no spaces at the start of a line
#161: FILE: ip/iplink_vxlan.c:426:
+        }$

total: 3 errors, 2 warnings, 80 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.