netdev - Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210723130851.6tfl4ijl7hkqzchm@skbuf>
Date:   Fri, 23 Jul 2021 16:08:51 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     davem@...emloft.net, shawnguo@...nel.org,
        linux-arm-kernel@...ts.infradead.org, qiangqing.zhang@....com,
        robh+dt@...nel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio
 #address-cells/#size-cells

Hi Fabio,

On Fri, Jul 23, 2021 at 08:28:35AM -0300, Fabio Estevam wrote:
> Since commit dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into
> phy device node") the following W=1 dtc warnings are seen:
> 
> arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (avoid_unnecessary_addr_size): /soc/bus@...0000/ethernet@...8000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> Remove the unnecessary mdio #address-cells/#size-cells to fix it.
> 
> Fixes: dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node")
> Signed-off-by: Fabio Estevam <festevam@...il.com>
> ---

Are you actually sure this is the correct fix? If I look at mdio.yaml, I
think it is pretty clear that the "ethernet-phy" subnode of the MDIO
controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If
it did, then it wouldn't warn about #address-cells.