netdev - Re: [PATCH iproute2-next 1/3] Add, show, link, remove IOAM namespaces and schemas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1447995787.25531985.1627052820048.JavaMail.zimbra@uliege.be>
Date:   Fri, 23 Jul 2021 17:07:00 +0200 (CEST)
From:   Justin Iurman <justin.iurman@...ege.be>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next 1/3] Add, show, link, remove IOAM
 namespaces and schemas

>> +		sprintf(data, "0x%" PRIx32,
>> +			(uint32_t)rta_getattr_u32(attrs[IOAM6_ATTR_NS_DATA]));
>> +
>> +		print_string(PRINT_ANY, "data", ", data %s", data)
> 
> The json_print has ability to handle hex already
> Why not
>	print_hex(PRINT_ANY, "data", ", data %#x",
> 		rta_getattr_u32(...


Hmmm, sorry for that, you're right. I already had this code ready for a long time and forgot to use print_hex instead (as I did for patch #2).