netdev - Re: [PATCH 08/54] dt-bindings: bluetooth: realtek: Add missing max-speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <a3605b89-6db0-41d6-9170-06711fe7384a@www.fastmail.com>
Date:   Sat, 24 Jul 2021 08:56:02 +1000
From:   Alistair <alistair@...stair23.me>
To:     "Maxime Ripard" <maxime@...no.tech>,
        "Chen-Yu Tsai" <wens@...e.org>,
        "Jernej Skrabec" <jernej.skrabec@...l.net>,
        devicetree@...r.kernel.org, "Rob Herring" <robh+dt@...nel.org>,
        "Frank Rowand" <frowand.list@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-sunxi@...glegroups.com,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>, netdev@...r.kernel.org,
        "Vasily Khoruzhick" <anarsoul@...il.com>
Subject: Re: [PATCH 08/54] dt-bindings: bluetooth: realtek: Add missing max-speed

On Thu, Jul 22, 2021, at 12:03 AM, Maxime Ripard wrote:
> additionalProperties prevent any property not explicitly defined in the
> binding to be used. Yet, some serial properties like max-speed are valid
> and validated through the serial/serial.yaml binding.
> 
> Even though the ideal solution would be to use unevaluatedProperties
> instead, it's not pratical due to the way the bus bindings have been
> described. Let's add max-speed to remove the warning.
> 
> Cc: Alistair Francis <alistair@...stair23.me>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org
> Cc: Vasily Khoruzhick <anarsoul@...il.com>
> Signed-off-by: Maxime Ripard <maxime@...no.tech>

Reviewed-by: Alistair Francis <alistair@...stair23.me>

Alistair

> ---
> Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> index 4f485df69ac3..deae94ef54b8 100644
> --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> @@ -34,6 +34,8 @@ properties:
>      maxItems: 1
>      description: GPIO specifier, used to wakeup the host processor
>  
> +  max-speed: true
> +
> required:
>    - compatible
>  
> -- 
> 2.31.1
> 
>