netdev - RE: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Jul 2021 05:21:29 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Fabio Estevam <festevam@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Shawn Guo <shawnguo@...nel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: RE: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio
 #address-cells/#size-cells


Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam <festevam@...il.com>
> Sent: 2021年7月23日 21:16
> To: Vladimir Oltean <olteanv@...il.com>
> Cc: David S. Miller <davem@...emloft.net>; Shawn Guo
> <shawnguo@...nel.org>; moderated list:ARM/FREESCALE IMX / MXC ARM
> ARCHITECTURE <linux-arm-kernel@...ts.infradead.org>; Joakim Zhang
> <qiangqing.zhang@....com>; Rob Herring <robh+dt@...nel.org>; netdev
> <netdev@...r.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@...r.kernel.org>
> Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio
> #address-cells/#size-cells
> 
> Hi Vladimr,
> 
> On Fri, Jul 23, 2021 at 10:08 AM Vladimir Oltean <olteanv@...il.com> wrote:
> 
> > Are you actually sure this is the correct fix? If I look at mdio.yaml,
> > I think it is pretty clear that the "ethernet-phy" subnode of the MDIO
> > controller must have an "@[0-9a-f]+$" pattern, and a "reg" property.
> > If it did, then it wouldn't warn about #address-cells.
> 
> Thanks for reviewing it.
> 
> After double-checking I realize that the correct fix would be to pass the phy
> address, like:
> 
> phy: ethernet-phy@1 {
> reg = <1>;
> 
> Since the Ethernet PHY address is design dependant, I can not make the fix
> myself.
> 
> I will try to ping the board maintainers for passing the correct phy address.

Thanks.

I prepare this patch to fix dtbs_check when convert fec binding into schema.
I realized that we need a "reg" under phy device node, but I also don't know how to add it since
the phy is obviously not on board. And I check the phy code, it supports auto scan for PHYs with empty
"reg" property.

Best Regards,
Joakim Zhang
> Thanks