netdev - Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9455e5b8-d994-732f-2c3d-88c7a98aaf86@gmail.com>
Date:   Sat, 24 Jul 2021 09:37:35 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Fabio Estevam <festevam@...il.com>
Cc:     davem@...emloft.net, shawnguo@...nel.org,
        linux-arm-kernel@...ts.infradead.org, qiangqing.zhang@....com,
        robh+dt@...nel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio
 #address-cells/#size-cells



On 7/23/2021 6:08 AM, Vladimir Oltean wrote:
> Hi Fabio,
> 
> On Fri, Jul 23, 2021 at 08:28:35AM -0300, Fabio Estevam wrote:
>> Since commit dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into
>> phy device node") the following W=1 dtc warnings are seen:
>>
>> arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (avoid_unnecessary_addr_size): /soc/bus@...0000/ethernet@...8000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>>
>> Remove the unnecessary mdio #address-cells/#size-cells to fix it.
>>
>> Fixes: dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node")
>> Signed-off-by: Fabio Estevam <festevam@...il.com>
>> ---
> 
> Are you actually sure this is the correct fix? If I look at mdio.yaml, I
> think it is pretty clear that the "ethernet-phy" subnode of the MDIO
> controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If

It is valid to omit the "reg" property of an Ethernet PHY which the 
kernel will then dynamically scan for. If you know the Ethernet PHY 
address it's obviously better to set it so you avoid scanning and the 
time spent in doing that. The boot loader could (should?) also provide 
that information to the kernel for the same reasons.
-- 
Florian