netdev - Re: [PATCH] bpf/tests: fix copy-and-paste error in double word test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzaT0kTdk3zzVK3SrVzHgYvfQw0ZsWcbyYdnvHdT7xySxA@mail.gmail.com>
Date:   Mon, 26 Jul 2021 13:06:52 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Johan Almbladh <johan.almbladh@...finetworks.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Tony Ambardar <Tony.Ambardar@...il.com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH] bpf/tests: fix copy-and-paste error in double word test

On Wed, Jul 21, 2021 at 3:41 AM Johan Almbladh
<johan.almbladh@...finetworks.com> wrote:
>
> This test now operates on DW as stated instead of W, which was
> already covered by another test.
>
> Signed-off-by: Johan Almbladh <johan.almbladh@...finetworks.com>
> ---

Don't know why patchbot didn't send notification, but this got applied
last Friday to bpf-next.

>  lib/test_bpf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index baff847a02da..f6d5d30d01bf 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -4286,8 +4286,8 @@ static struct bpf_test tests[] = {
>                 .u.insns_int = {
>                         BPF_LD_IMM64(R0, 0),
>                         BPF_LD_IMM64(R1, 0xffffffffffffffffLL),
> -                       BPF_STX_MEM(BPF_W, R10, R1, -40),
> -                       BPF_LDX_MEM(BPF_W, R0, R10, -40),
> +                       BPF_STX_MEM(BPF_DW, R10, R1, -40),
> +                       BPF_LDX_MEM(BPF_DW, R0, R10, -40),
>                         BPF_EXIT_INSN(),
>                 },
>                 INTERNAL,
> --
> 2.25.1
>