netdev - Re: [PATCH v2 1/2] net: ethtool: Support setting ntuple rule count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3bc237a32a1e823739e4e15df9758171c4051a66.camel@kernel.org>
Date:   Mon, 26 Jul 2021 15:29:24 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>, Sunil Goutham <sgoutham@...vell.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH v2 1/2] net: ethtool: Support setting ntuple rule count

On Sat, 2021-07-24 at 19:23 +0200, Andrew Lunn wrote:
> On Fri, Jul 23, 2021 at 11:46:45PM +0530, Sunil Goutham wrote:
> > Some NICs share resources like packet filters across
> > multiple interfaces they support. From HW point of view
> > it is possible to use all filters for a single interface.
> > Currently ethtool doesn't support modifying filter count so
> > that user can allocate more filters to a interface and less
> > to others. This patch adds ETHTOOL_SRXCLSRLCNT ioctl command
> > for modifying filter count.
> > 
> > example command:
> > ./ethtool -U eth0 rule-count 256
> 
> How can use see what the current usage is? How many in total you have
> available?  What the current split is between the interfaces?
> 

There is no point of adding this ethtool interface if the orchestration
tool already knows the "rule-count" in advance, it's just redundant to
have a user managed limiting device in ethtool.

> You say:
> 
>    * Jakub suggested if devlink-resource can be used for this.
> 
> devlink-resource provides you a standardised mechanism to answer the
> questions i just asked. So i would have to agree with Jakub.
> 

+1, devlink is your address when a single device is shared across
multiple interfaces.

>           Andrew