netdev - Re: [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the missing argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a73ed66-feb8-d85c-dfbe-4ae7005608db@fb.com>
Date:   Sun, 25 Jul 2021 19:34:03 -0700
From:   Yonghong Song <yhs@...com>
To:     Juhee Kang <claudiajkang@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>
CC:     <netdev@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the
 missing argument



On 7/24/21 8:21 AM, Juhee Kang wrote:
> The current behavior of 'tracex7' doesn't consist with other bpf samples
> tracex{1..6}. Other samples do not require any argument to run with, but
> tracex7 should be run with btrfs device argument. (it should be executed
> with test_override_return.sh)
> 
> Currently, tracex7 doesn't have any description about how to run this
> program and raises an unexpected error. And this result might be
> confusing since users might not have a hunch about how to run this
> program.
> 
>      // Current behavior
>      # ./tracex7
>      sh: 1: Syntax error: word unexpected (expecting ")")
>      // Fixed behavior
>      # ./tracex7
>      ERROR: Run with the btrfs device argument!
> 
> In order to fix this error, this commit adds logic to report a message
> and exit when running this program with a missing argument.
> 
> Additionally in test_override_return.sh, there is a problem with
> multiple directory(tmpmnt) creation. So in this commit adds a line with
> removing the directory with every execution.
> 
> Signed-off-by: Juhee Kang <claudiajkang@...il.com>

Acked-by: Yonghong Song <yhs@...com>