netdev - Re: [PATCH] ethernet/intel: fix PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jul 2021 14:27:25 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jacob Keller <jacob.e.keller@...el.com>,
        kbuild-all@...ts.01.org, Networking <netdev@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        Dave Ertman <david.m.ertman@...el.com>
Subject: Re: [PATCH] ethernet/intel: fix PTP_1588_CLOCK dependencies

On Mon, Jul 26, 2021 at 12:29 PM kernel test robot <lkp@...el.com> wrote:

> >> drivers/i2c/Kconfig:8:error: recursive dependency detected!
>    drivers/i2c/Kconfig:8: symbol I2C is selected by IGB
>    drivers/net/ethernet/intel/Kconfig:87: symbol IGB depends on PTP_1588_CLOCK
>    drivers/ptp/Kconfig:8: symbol PTP_1588_CLOCK is implied by MLX4_EN
>    drivers/net/ethernet/mellanox/mlx4/Kconfig:6: symbol MLX4_EN depends on NET_VENDOR_MELLANOX
>    drivers/net/ethernet/mellanox/Kconfig:6: symbol NET_VENDOR_MELLANOX depends on I2C
>    For a resolution refer to Documentation/kbuild/kconfig-language.rst
>    subsection "Kconfig recursive dependency limitations"

Sorry about this, the patch I was testing with has this additional hunk

@@ -88,7 +88,7 @@ config IGB
        tristate "Intel(R) 82575/82576 PCI-Express Gigabit Ethernet support"
        depends on PCI
        depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
-       select I2C
+       depends on I2C
        select I2C_ALGOBIT
        help
          This driver supports Intel(R) 82575/82576 gigabit ethernet family of

that I even describe in the changelog but forgot to include in the patch I sent.

        Arnd