netdev - Re: [PATCH bpf v2 3/3] bpf, sockmap: fix memleak on ingress msg enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61002dee75048_199a412083e@john-XPS-13-9370.notmuch>
Date:   Tue, 27 Jul 2021 09:01:50 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Martin KaFai Lau <kafai@...com>,
        John Fastabend <john.fastabend@...il.com>
Cc:     jakub@...udflare.com, daniel@...earbox.net,
        xiyou.wangcong@...il.com, alexei.starovoitov@...il.com,
        bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf v2 3/3] bpf, sockmap: fix memleak on ingress msg
 enqueue

Martin KaFai Lau wrote:
> On Mon, Jul 26, 2021 at 09:53:04AM -0700, John Fastabend wrote:
> > --- a/include/linux/skmsg.h
> > +++ b/include/linux/skmsg.h
> > @@ -285,11 +285,45 @@ static inline struct sk_psock *sk_psock(const struct sock *sk)
> >  	return rcu_dereference_sk_user_data(sk);
> >  }
> >  
> > +static inline void sk_psock_set_state(struct sk_psock *psock,
> > +				      enum sk_psock_state_bits bit)
> > +{
> > +	set_bit(bit, &psock->state);
> > +}
> > +
> > +static inline void sk_psock_clear_state(struct sk_psock *psock,
> > +					enum sk_psock_state_bits bit)
> > +{
> > +	clear_bit(bit, &psock->state);
> > +}
> > +
> > +static inline bool sk_psock_test_state(const struct sk_psock *psock,
> > +				       enum sk_psock_state_bits bit)
> > +{
> > +	return test_bit(bit, &psock->state);
> > +}
> > +
> > +static void sock_drop(struct sock *sk, struct sk_buff *skb)
> inline


Thanks will fix, bit surprised I didn't get a build warning for the typo.