netdev - Re: [PATCH net-next 2/5] dt-bindings: net: Add tsnep Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Jul 2021 14:25:06 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        netdev <netdev@...r.kernel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 2/5] dt-bindings: net: Add tsnep Ethernet controller

On Tue, Jul 27, 2021 at 12:35 PM Gerhard Engleder
<gerhard@...leder-embedded.com> wrote:
>
> On Tue, Jul 27, 2021 at 1:35 AM Rob Herring <robh+dt@...nel.org> wrote:
> > > +properties:
> > > +  compatible:
> > > +    oneOf:
> >
> > Don't need oneOf when there is only one entry.
>
> I will fix that.
>
> > > +      - enum:
> > > +        - engleder,tsnep
> >
> > tsnep is pretty generic. Only 1 version ever? Or differences are/will
> > be discoverable by other means.
>
> Differences shall be detected by flags in the registers; e.g., a flag for
> gate control support. Anyway a version may make sense. Can you
> point to a good reference binding with versions? I did not find a
> network controller binding with versions.

Some of the SiFive IP blocks have versions. Version numbers are the
exception though. Ideally they would correspond to some version of
your FPGA image. I just don't want to see 'v1' because that sounds
made up. The above string can mean 'v1' or whatever version you want.
I'm fine if you just add some description here about feature flag
registers.

>
> > > +  reg: true
> >
> > How many? And what is each entry if more than 1.
>
> Only one. I will fix that.
>
> > > +  interrupts: true
> >
> > How many?
>
> Only one. I will fix that.
>
> > > +
> > > +  local-mac-address: true
> > > +  mac-address: true
> > > +  nvmem-cells: true
> >
> > How many?
>
> Is that not inherited from ethernet-controller.yaml?
>   nvmem-cells:
>     maxItems: 1

Ah, right.

> > > +  nvmem-cells-names: true
> >
> > Need to define the names.
>
> Is that not inherited from ethernet-controller.yaml?
>   nvmem-cell-names:
>     const: mac-address

Yes.

Rob