netdev - Re: [PATCH net-next] bonding: add new option lacp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3752.1627499438@famine>
Date:   Wed, 28 Jul 2021 12:10:38 -0700
From:   Jay Vosburgh <jay.vosburgh@...onical.com>
To:     Jiri Pirko <jiri@...nulli.us>
cc:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Jarod Wilson <jarod@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] bonding: add new option lacp_active

Jiri Pirko <jiri@...nulli.us> wrote:

>Wed, Jul 28, 2021 at 11:52:29AM CEST, liuhangbin@...il.com wrote:
>
>[...]
>
>>+module_param(lacp_active, int, 0);
>>+MODULE_PARM_DESC(lacp_active, "Send LACPDU frames as the configured lacp_rate or acts as speak when spoken to; "
>>+			      "0 for off, 1 for on (default)");
>
>Afaik adding module parameters is not allowed.

	Correct; also, adding options requires adding support to
iproute2 to handle the new options via netlink.

	-J

---
	-Jay Vosburgh, jay.vosburgh@...onical.com