lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Jul 2021 12:14:35 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: dsterba@...e.cz, Kees Cook <keescook@...omium.org>, linux-hardening@...r.kernel.org, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Keith Packard <keithpac@...zon.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-staging@...ts.linux.dev, linux-block@...r.kernel.org, linux-kbuild@...r.kernel.org, clang-built-linux@...glegroups.com, nborisov@...e.com Subject: Re: [PATCH 01/64] media: omap3isp: Extract struct group for memcpy() region On Wed, Jul 28, 2021 at 10:59:22AM +0200, David Sterba wrote: > > drivers/media/platform/omap3isp/ispstat.c | 5 +-- > > include/uapi/linux/omap3isp.h | 44 +++++++++++++++++------ > > 2 files changed, 36 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c > > index 5b9b57f4d9bf..ea8222fed38e 100644 > > --- a/drivers/media/platform/omap3isp/ispstat.c > > +++ b/drivers/media/platform/omap3isp/ispstat.c > > @@ -512,7 +512,7 @@ int omap3isp_stat_request_statistics(struct ispstat *stat, > > int omap3isp_stat_request_statistics_time32(struct ispstat *stat, > > struct omap3isp_stat_data_time32 *data) > > { > > - struct omap3isp_stat_data data64; > > + struct omap3isp_stat_data data64 = { }; > > Should this be { 0 } ? > > We've seen patches trying to switch from { 0 } to { } but the answer > was that { 0 } is supposed to be used, > http://www.ex-parrot.com/~chris/random/initialise.html > > (from https://lore.kernel.org/lkml/fbddb15a-6e46-3f21-23ba-b18f66e3448a@suse.com/) In the kernel we don't care about portability so much. Use the = { } GCC extension. If the first member of the struct is a pointer then Sparse will complain about = { 0 }. I had a patch to make checkpatch.pl complain about = { 0 }; but my system died and I haven't transfered my postponed messages to the new system... regards, dan carpenter
Powered by blists - more mailing lists