netdev - Re: net: dsa: mv88e6xxx: no multicasts rx'd after enabling hw time stamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFSKS=OX2ngU=sTYBi7x4ehOxOUb0ya5brr2U0Dy1ZqbdU-YTg@mail.gmail.com>
Date:   Thu, 29 Jul 2021 08:09:45 -0500
From:   George McCollister <george.mccollister@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev <netdev@...r.kernel.org>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: net: dsa: mv88e6xxx: no multicasts rx'd after enabling hw time stamping

Ugh, I replied to this last night from gmail on my phone and it seems
to have sent it in HTML as well as plain text. Let's try this again...

On Wed, Jul 28, 2021 at 4:05 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Wed, Jul 28, 2021 at 03:44:24PM -0500, George McCollister wrote:
> > If I do the following on one of my mv88e6390 switch ports I stop
> > receiving multicast frames.
> > hwstamp_ctl -i lan0 -t 1 -r 12
> >
> > Has anyone seen anything like this or have any ideas what might be
> > going on? Does anyone have PTP working on the mv88e6390?
> >
> > I tried this but it doesn't help:
> > ip maddr add 01:xx:xx:xx:xx:xx dev lan0
> >
> > I've tried sending 01:1B:19:00:00:00, 01:80:C2:00:00:0E as well as
> > other random ll multicast addresses. Nothing gets through once
> > hardware timestamping is switched on. The switch counters indicate
> > they're making it into the outward facing switch port but are not
> > being sent out the CPU facing switch port. I ran into this while
> > trying to get ptp4l to work.
>
> Hi George
>
> All my testing was i think on 6352.
>
> I assume you get multicast before using hwstamp_ctl?

Yup.

>
> Maybe use:
>
> https://github.com/lunn/mv88e6xxx_dump
>
> and dump the ATU before and afterwards.

Ooh. Thanks, this will probably help!

>
> The 6390 family introduced a new way to configured which reserved
> management addresses get forwarded to the CPU. Maybe take a look at
> mv88e6390_g1_mgmt_rsvd2cpu() and see if you can spot anything odd
> going on.

Yes I looked at this and spent a lot of time reading the datasheet but
maybe I've still missed something.

>
> You might also want to check if mv88e6352_port_set_mcast_flood() is
> being called.

I'm pretty sure I did at one point but I'll double check, thanks.

>
>       Andrew