netdev - Re: [PATCH net-next] net: dsa: don't set skb->offload_fwd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Jul 2021 21:20:05 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        f.fainelli@...il.com, andrew@...n.ch, vivien.didelot@...il.com,
        tobias@...dekranz.com, dqfext@...il.com
Subject: Re: [PATCH net-next] net: dsa: don't set skb->offload_fwd_mark when not
 offloading the bridge

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 29 Jul 2021 17:56:00 +0300 you wrote:
> DSA has gained the recent ability to deal gracefully with upper
> interfaces it cannot offload, such as the bridge, bonding or team
> drivers. When such uppers exist, the ports are still in standalone mode
> as far as the hardware is concerned.
> 
> But when we deliver packets to the software bridge in order for that to
> do the forwarding, there is an unpleasant surprise in that the bridge
> will refuse to forward them. This is because we unconditionally set
> skb->offload_fwd_mark = true, meaning that the bridge thinks the frames
> were already forwarded in hardware by us.
> 
> [...]

Here is the summary with links:
  - [net-next] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge
    https://git.kernel.org/netdev/net-next/c/bea7907837c5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html