netdev - Re: [PATCH] Revert "net: Get rid of consume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Jul 2021 04:10:33 +0000
From:   yajun.deng@...ux.dev
To:     "Herbert Xu" <herbert@...dor.apana.org.au>
Cc:     davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] Revert "net: Get rid of consume_skb when tracing is
 off"

July 29, 2021 12:03 PM, "Herbert Xu" <herbert@...dor.apana.org.au> wrote:

> On Thu, Jul 29, 2021 at 04:01:28AM +0000, yajun.deng@...ux.dev wrote:
> 
>> if we don't define CONFIG_TRACEPOINTS, consume_skb() wolud called kfree_skb(), there have
>> trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is also a trace function. So we
>> can trace consume_skb() even if we don't define CONFIG_TRACEPOINTS.
>> This patch "net: Get rid of consume_skb when tracing is off" does not seem to be effective.
> 
> The point of my patch was to get rid of consume_skb because its
> only purpose is to provide extra information for tracing. If you're
> not tracing then you don't need that extra information (and overhead).
> 
Ok, I didn't understand it well. 
> Cheers,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt