netdev - Re: [PATCH net-next 1/3] net: dsa: sja1105: reset the port pvid when leaving a VLAN-aware bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jul 2021 21:22:13 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 1/3] net: dsa: sja1105: reset the port pvid when
 leaving a VLAN-aware bridge



On 7/28/2021 2:54 PM, Vladimir Oltean wrote:
> Now that we no longer have the ultra-central sja1105_build_vlan_table(),
> we need to be more careful about checking all corner cases manually.
> 
> For example, when a port leaves a VLAN-aware bridge, it becomes
> standalone so its pvid should become a tag_8021q RX VLAN again. However,
> sja1105_commit_pvid() only gets called from sja1105_bridge_vlan_add()
> and from sja1105_vlan_filtering(), and no VLAN awareness change takes
> place (VLAN filtering is a global setting for sja1105, so the switch
> remains VLAN-aware overall).
> 
> This means that we need to put another sja1105_commit_pvid() call in
> sja1105_bridge_member().
> 
> Fixes: 6dfd23d35e75 ("net: dsa: sja1105: delete vlan delta save/restore logic")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian