netdev - Re: [PATCH net-next] net: dsa: mt7530: drop paranoid checks in .get_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210731140800.ahs6lyrcekbxsycn@skbuf>
Date:   Sat, 31 Jul 2021 17:08:00 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH net-next] net: dsa: mt7530: drop paranoid checks in
 .get_tag_protocol()

On Fri, Jul 30, 2021 at 08:08:43PM -0700, Florian Fainelli wrote:
> On 7/30/2021 3:57 PM, Vladimir Oltean wrote:
> > It is desirable to reduce the surface of DSA_TAG_PROTO_NONE as much as
> > we can, because we now have options for switches without hardware
> > support for DSA tagging, and the occurrence in the mt7530 driver is in
> > fact quite gratuitout and easy to remove. Since ds->ops->get_tag_protocol()
> > is only called for CPU ports, the checks for a CPU port in
> > mtk_get_tag_protocol() are redundant and can be removed.
> 
> The point of the check was in case the designated CPU port from device
> tree/platform data would not match what the Mediatek driver supports,
> similar to what b53 does in the same vein. I am fine with removing that
> check for mt7530 as it does not look like there is an use case where the CPU
> port is not actually MT7530_CPU_PORT.

So if mt7530 only supports port 6 as a CPU port, how is Qingfang testing
multiple CPU ports on it?