netdev - Re: [PATCH net-next] ptp: ocp: Expose various resources on the timecard.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210731080637.231d89e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 31 Jul 2021 08:06:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     <davem@...emloft.net>, <richardcochran@...il.com>,
        <netdev@...r.kernel.org>, <kernel-team@...com>
Subject: Re: [PATCH net-next] ptp: ocp: Expose various resources on the
 timecard.

On Fri, 30 Jul 2021 13:13:54 -0700 Jonathan Lemon wrote:
> The OpenCompute timecard driver has additional functionality besides
> a clock.  Make the following resources available:
> 
>  - The external timestamp channels (ts0/ts1)
>  - devlink support for flashing and health reporting
>  - GPS and MAC serial ports
>  - board serial number (obtained from i2c device)
> 
> Also add watchdog functionality for when GNSS goes into holdover.

drivers/ptp/ptp_ocp.c: In function ‘ptp_ocp_init’:
drivers/ptp/ptp_ocp.c:1600:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
1600 |  int err;
     |      ^~~
drivers/ptp/ptp_ocp.c:1153:69: warning: Using plain integer as NULL pointer
drivers/ptp/ptp_ocp.c:1506:27: warning: Using plain integer as NULL pointer
drivers/ptp/ptp_ocp.c:1587:31: warning: Using plain integer as NULL pointer
drivers/ptp/ptp_ocp.c:881:29: warning: dereference of noderef expression
drivers/ptp/ptp_ocp.c:1399:29: warning: dereference of noderef expression