netdev - Re: [PATCH] atm: [nicstar] make drain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210731093351.39c0e305@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 31 Jul 2021 09:33:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jordy Zomer <jordy@...ing.systems>
Cc:     netdev@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chas Williams <3chas3@...il.com>,
        linux-atm-general@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: [nicstar] make drain_scq explicitly unsigned

On Sat, 31 Jul 2021 10:54:28 +0200 Jordy Zomer wrote:
> The drain_scq function used to take a signed integer as a pos parameter.
> The only caller of this function passes an unsigned integer to it.
> Therefore to make it obviously safe, let's just make this an unsgined
> integer as this is used in pointer arithmetics.
> 
> Signed-off-by: Jordy Zomer <jordy@...ing.systems>

Does not build.