netdev - net: intel/e1000e/netdev.c __ew32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN6UTaw7Rtoz4q-AsDjKbTm7_sU8BrTAmuMp8-wr6FzaxDMe2Q@mail.gmail.com>
Date:   Mon, 2 Aug 2021 11:55:56 -0300
From:   Leandro Coutinho <lescoutinhovr@...il.com>
To:     netdev@...r.kernel.org
Subject: net: intel/e1000e/netdev.c __ew32_prepare parameter not used?

Hi,

I'm a newbie and I was just looking at the code to learn.

It seems the parameter `*hw` is not used.
Although I didn't find where `FWSM` is defined.

Should it be removed? Or is the parameter really needed?

```c
static void __ew32_prepare(struct e1000_hw *hw)
{
    s32 i = E1000_ICH_FWSM_PCIM2PCI_COUNT;

    while ((er32(FWSM) & E1000_ICH_FWSM_PCIM2PCI) && --i)
        udelay(50);
}
```

It's because it gives an impression that "hw" is being changed somehow.

If you think it should be removed, I can send a patch.