lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 2 Aug 2021 17:02:57 +0200
From:   Andrew Lunn <>
To:     Biju Das <>
Cc:     "David S. Miller" <>,
        Jakub Kicinski <>,
        Sergei Shtylyov <>,
        Geert Uytterhoeven <>,
        Sergey Shtylyov <>,
        Adam Ford <>,
        Yuusuke Ashizuka <>,
        Yoshihiro Shimoda <>,,,
        Chris Paterson <>,
        Biju Das <>,
        Prabhakar Mahadev Lad <>
Subject: Re: [PATCH net-next v2 1/8] ravb: Add struct ravb_hw_info to driver

On Mon, Aug 02, 2021 at 11:26:47AM +0100, Biju Das wrote:
> The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are
> similar to the R-Car Ethernet AVB IP. With a few changes in the driver we
> can support both IPs.
> Currently a runtime decision based on the chip type is used to distinguish
> the HW differences between the SoC families.
> The number of TX descriptors for R-Car Gen3 is 1 whereas on R-Car Gen2 and
> RZ/G2L it is 2. For cases like this it is better to select the number of
> TX descriptors by using a structure with a value, rather than a runtime
> decision based on the chip type.
> This patch adds the num_tx_desc variable to struct ravb_hw_info and also
> replaces the driver data chip type with struct ravb_hw_info by moving chip
> type to it.
> Signed-off-by: Biju Das <>
> Reviewed-by: Lad Prabhakar <>

Hi Biju

This is better. A lot clearer what is going on. I personally would of
done the num_tx_desc change as a separate patch, but this is O.K.

Reviewed-by: Andrew Lunn <>


Powered by blists - more mailing lists