lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Aug 2021 09:40:54 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Loic Poulain <loic.poulain@...aro.org> Cc: netdev@...r.kernel.org, johannes@...solutions.net, richard.laing@...iedtelesis.co.nz Subject: Re: [PATCH net-next RESEND 1/2] net: wwan: Add MHI MBIM network driver On Mon, 2 Aug 2021 09:51:02 +0200 Loic Poulain wrote: > Add new wwan driver for MBIM over MHI. MBIM is a transport protocol > for IP packets, allowing packet aggregation and muxing. Initially > designed for USB bus, it is also exposed through MHI bus for QCOM > based PCIe wwan modems. > > This driver supports the new wwan rtnetlink interface for multi-link > management and has been tested with Quectel EM120R-GL M2 module. Let's make sure it builds cleanly with W=1 C=1 first. drivers/net/wwan/mhi_wwan_mbim.c:83:23: warning: no previous prototype for ‘mhi_mbim_get_link’ [-Wmissing-prototypes] 83 | struct mhi_mbim_link *mhi_mbim_get_link(struct mhi_mbim_context *mbim, | ^~~~~~~~~~~~~~~~~ drivers/net/wwan/mhi_wwan_mbim.c:83:22: warning: symbol 'mhi_mbim_get_link' was not declared. Should it be static? Also - please start putting someone in the To: header, preferably the maintainer / mailing list thru which you expect the code to be merged.
Powered by blists - more mailing lists