netdev - Re: [PATCH net-next] pktgen: Fix invalid clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210802170910.2190218-1-richardsonnick@google.com>
Date:   Mon,  2 Aug 2021 17:09:10 +0000
From:   Nicholas Richardson <richardsonnick@...gle.com>
To:     kuba@...nel.org
Cc:     nrrichar@...u.edu, arunkaly@...gle.com, netdev@...r.kernel.org,
        Nicholas Richardson <richardsonnick@...gle.com>
Subject: Re: [PATCH net-next] pktgen: Fix invalid clone_skb override

When a user passes a negative value for clone_skb, the num_args() function stops parsing at the first nonnumeric value. This makes it impossible for clone_skb to be set to a negative value. For example: "clone_skb -200" would stop parsing at the first char ('-') and return zero for the new clone_skb value.

So to answer your question: No clone_skb cannot be negative.

Apologies for the email format errors and thanks for the quick reply!