lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Aug 2021 19:22:58 +0200 From: Loic Poulain <loic.poulain@...aro.org> To: Jakub Kicinski <kuba@...nel.org> Cc: Network Development <netdev@...r.kernel.org>, Johannes Berg <johannes@...solutions.net>, Richard Laing <richard.laing@...iedtelesis.co.nz> Subject: Re: [PATCH net-next RESEND 1/2] net: wwan: Add MHI MBIM network driver On Mon, 2 Aug 2021 at 18:40, Jakub Kicinski <kuba@...nel.org> wrote: > > On Mon, 2 Aug 2021 09:51:02 +0200 Loic Poulain wrote: > > Add new wwan driver for MBIM over MHI. MBIM is a transport protocol > > for IP packets, allowing packet aggregation and muxing. Initially > > designed for USB bus, it is also exposed through MHI bus for QCOM > > based PCIe wwan modems. > > > > This driver supports the new wwan rtnetlink interface for multi-link > > management and has been tested with Quectel EM120R-GL M2 module. > > Let's make sure it builds cleanly with W=1 C=1 first. Sure. > > drivers/net/wwan/mhi_wwan_mbim.c:83:23: warning: no previous prototype for ‘mhi_mbim_get_link’ [-Wmissing-prototypes] > 83 | struct mhi_mbim_link *mhi_mbim_get_link(struct mhi_mbim_context *mbim, > | ^~~~~~~~~~~~~~~~~ > drivers/net/wwan/mhi_wwan_mbim.c:83:22: warning: symbol 'mhi_mbim_get_link' was not declared. Should it be static? > > Also - please start putting someone in the To: header, preferably the > maintainer / mailing list thru which you expect the code to be merged. Not sure why my `git send-email` keeps ignoring the to field for that series, but going to fix that, thanks for pointing this. Regards, Loic
Powered by blists - more mailing lists