lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Aug 2021 21:45:14 +0200 From: Andrew Lunn <andrew@...n.ch> To: Vladimir Oltean <olteanv@...il.com> Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Russell King <linux@...linux.org.uk>, Pengutronix Kernel Team <kernel@...gutronix.de>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org Subject: Re: [PATCH net-next v3 2/6] net: dsa: qca: ar9331: make proper initial port defaults > > +/* AGE_TIME_COEF is not documented. This is "works for me" value */ > > +#define AR9331_SW_AT_AGE_TIME_COEF 6900 > > Not documented, not used either, it seems. > "Works for you" based on what? It is used in a later patch. Ideally it would of been introduced in that patch to make this more obvious. > > #define AR9331_SW_REG_MDIO_CTRL 0x98 > > #define AR9331_SW_MDIO_CTRL_BUSY BIT(31) > > #define AR9331_SW_MDIO_CTRL_MASTER_EN BIT(30) > > @@ -101,6 +111,46 @@ > > AR9331_SW_PORT_STATUS_RX_FLOW_EN | AR9331_SW_PORT_STATUS_TX_FLOW_EN | \ > > AR9331_SW_PORT_STATUS_SPEED_M) > > Is this patch material for "net"? If standalone ports is all that ar9331 > supports, then it would better not do packet forwarding in lack of a > bridge device. It does seem like this patch should be considered for stable, if by default all ports can talk with all ports when not part of a bridge. Andrew
Powered by blists - more mailing lists