lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Aug 2021 17:22:18 -0400 (EDT) From: Nicolas Pitre <nico@...xnic.net> To: Arnd Bergmann <arnd@...nel.org> cc: "Keller, Jacob E" <jacob.e.keller@...el.com>, Richard Cochran <richardcochran@...il.com>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Arnd Bergmann <arnd@...db.de>, Kurt Kanzenbach <kurt@...utronix.de>, "Saleem, Shiraz" <shiraz.saleem@...el.com>, "Ertman, David M" <david.m.ertman@...el.com>, "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies On Mon, 2 Aug 2021, Arnd Bergmann wrote: > On Mon, Aug 2, 2021 at 10:46 PM Keller, Jacob E > <jacob.e.keller@...el.com> wrote: > > > > You can do something like it for a particular symbol though, such as > > > > > > config MAY_USE_PTP_1588_CLOCK > > > def_tristate PTP_1588_CLOCK || !PTP_1588_CLOCK > > > > > > config E1000E > > > tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support" > > > depends on PCI && (!SPARC32 || BROKEN) > > > + depends on MAY_USE_PTP_1588_CLOCK > > > select CRC32 > > > - imply PTP_1588_CLOCK > > > > What about "integrates"? > > Maybe, we'd need to look at whether that fits for the other users of the > "A || !A" trick. I implemented "conditional dependencies" at the time, which is syntactic sugar to express the above as: depends on A if A != n depends on A if A etc. http://lkml.iu.edu/hypermail/linux/kernel/2004.2/09783.html But Masahiro shut it down. Nicolas
Powered by blists - more mailing lists