lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 2 Aug 2021 08:52:44 +0000
From:   zhengyongjun <zhengyongjun3@...wei.com>
To:     Hoang Huu Le <hoang.h.le@...tech.com.au>,
        "jmaloy@...hat.com" <jmaloy@...hat.com>,
        "ying.xue@...driver.com" <ying.xue@...driver.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH net-next] tipc: Return the correct errno code

Hi hoang,

I don't notice that patch has been merged, If you need me to send a revert patch, I will send it as soon as possible.
If you submit the revert patch by your team, it's also ok. 

Thanks,
Zheng

-----邮件原件-----
发件人: Hoang Huu Le [mailto:hoang.h.le@...tech.com.au] 
发送时间: 2021年8月2日 16:02
收件人: zhengyongjun <zhengyongjun3@...wei.com>; jmaloy@...hat.com; ying.xue@...driver.com; davem@...emloft.net; kuba@...nel.org; netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net; linux-kernel@...r.kernel.org
主题: RE: [PATCH net-next] tipc: Return the correct errno code

Hi Zheng,

The patch was being merged by accident. Will have you planning to revert it?
We need to do ASAP since calling path tipc_node_xmit() -> tipc_link_xmit() broken as side effect.

Thanks,
hoang
> -----Original Message-----
> From: zhengyongjun <zhengyongjun3@...wei.com>
> Sent: Friday, June 4, 2021 8:35 AM
> To: jmaloy@...hat.com; ying.xue@...driver.com; davem@...emloft.net; 
> kuba@...nel.org; netdev@...r.kernel.org; tipc- 
> discussion@...ts.sourceforge.net; linux-kernel@...r.kernel.org
> Subject: 答复: [PATCH net-next] tipc: Return the correct errno code
> 
> Sorry, this patch is wrong, please ignore it, thanks :)
> 
> -----邮件原件-----
> 发件人: zhengyongjun
> 发送时间: 2021年6月4日 9:47
> 收件人: jmaloy@...hat.com; ying.xue@...driver.com; davem@...emloft.net; 
> kuba@...nel.org; netdev@...r.kernel.org; tipc- 
> discussion@...ts.sourceforge.net; linux-kernel@...r.kernel.org
> 抄送: zhengyongjun <zhengyongjun3@...wei.com>
> 主题: [PATCH net-next] tipc: Return the correct errno code
> 
> When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  net/tipc/link.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/tipc/link.c b/net/tipc/link.c index 
> c44b4bfaaee6..5b6181277cc5 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -912,7 +912,7 @@ static int link_schedule_user(struct tipc_link *l, struct tipc_msg *hdr)
>  	skb = tipc_msg_create(SOCK_WAKEUP, 0, INT_H_SIZE, 0,
>  			      dnode, l->addr, dport, 0, 0);
>  	if (!skb)
> -		return -ENOBUFS;
> +		return -ENOMEM;
>  	msg_set_dest_droppable(buf_msg(skb), true);
>  	TIPC_SKB_CB(skb)->chain_imp = msg_importance(hdr);
>  	skb_queue_tail(&l->wakeupq, skb);
> @@ -1030,7 +1030,7 @@ void tipc_link_reset(struct tipc_link *l)
>   *
>   * Consumes the buffer chain.
>   * Messages at TIPC_SYSTEM_IMPORTANCE are always accepted
> - * Return: 0 if success, or errno: -ELINKCONG, -EMSGSIZE or -ENOBUFS
> + * Return: 0 if success, or errno: -ELINKCONG, -EMSGSIZE or -ENOBUFS 
> + or -ENOMEM
>   */
>  int tipc_link_xmit(struct tipc_link *l, struct sk_buff_head *list,
>  		   struct sk_buff_head *xmitq)
> @@ -1088,7 +1088,7 @@ int tipc_link_xmit(struct tipc_link *l, struct sk_buff_head *list,
>  			if (!_skb) {
>  				kfree_skb(skb);
>  				__skb_queue_purge(list);
> -				return -ENOBUFS;
> +				return -ENOMEM;
>  			}
>  			__skb_queue_tail(transmq, skb);
>  			tipc_link_set_skb_retransmit_time(skb, l);
> --
> 2.25.1

Powered by blists - more mailing lists