lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 3 Aug 2021 02:01:21 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] net: fec: fix MAC internal delay doesn't work


> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: 2021年8月3日 4:33
> To: Joakim Zhang <qiangqing.zhang@....com>
> Cc: davem@...emloft.net; andrew@...n.ch; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work
> 
> On Fri, 30 Jul 2021 19:47:09 +0800 Joakim Zhang wrote:
> > @@ -3806,6 +3827,10 @@ fec_probe(struct platform_device *pdev)
> >  		fep->phy_interface = interface;
> >  	}
> >
> > +	ret = fec_enet_parse_rgmii_delay(fep, np);
> > +	if (ret)
> > +		goto failed_phy;
> 
> You're jumping to the wrong label, it looks like phy_node needs to be released
> at this point.

Yes, I will correct it. Thanks Jakub.

Best Regards,
Joakim Zhang

Powered by blists - more mailing lists