netdev - Re: [PATCH v2] sock: allow reading and changing sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Aug 2021 05:42:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pavel Tikhomirov <ptikhomirov@...tuozzo.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd@...db.de>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Florian Westphal <fw@...len.de>, linux-kernel@...r.kernel.org,
        linux-alpha@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-arch@...r.kernel.org, Andrei Vagin <avagin@...il.com>
Subject: Re: [PATCH v2] sock: allow reading and changing sk_userlocks with
 setsockopt

On Tue, 3 Aug 2021 14:04:39 +0300 Pavel Tikhomirov wrote:
> > Just to double check - is the expectation that the value returned is
> > completely opaque to the user space? The defines in question are not
> > part of uAPI.  
> 
> Sorry, didn't though about it initially. For criu we don't care about 
> the actual bits we restore same what we've dumped. Buf if some real 
> users would like to use this interface to restore default autoadjustment 
> on their sockets we should probably export SOCK_SNDBUF_LOCK and 
> SOCK_RCVBUF_LOCK to uAPI.

Just to be sure - please mention this in the commit message.