netdev - Re: [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35877a55-3dc3-abb1-5aa4-1d7edaa85602@canonical.com>
Date:   Tue, 3 Aug 2021 15:03:34 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Joe Perches <joe@...ches.com>, Ping-Ke Shih <pkshih@...ltek.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable
 initializations

On 02/08/2021 09:35, Joe Perches wrote:
> On Sat, 2021-07-31 at 13:40 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The variables rtstatus and place are being initialized with a values that
>> are never read, the initializations are redundant and can be removed.
> 
> trivia:
> 
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> []
>> @@ -1362,7 +1362,7 @@ u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
>>  		132, 134, 136, 138, 140, 149, 151, 153, 155,
>>  		157, 159, 161, 163, 165
>>  	};
>> -	u8 place = chnl;
>> +	u8 place;
>>  
>>
>>  	if (chnl > 14) {
>>  		for (place = 14; place < sizeof(channel_all); place++) {
> 
> This line should probably be
> 
> 		for (place = 14; place < ARRAY_SIZE(channel_all); place++) {
> 

Nice catch, will send a V2.