netdev - Re: [PATCH net 1/2] net: usb: pegasus: Check the return value of get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58f9122f-3ad3-9d6b-7ae3-5d5a83f19334@gmail.com>
Date:   Tue, 3 Aug 2021 18:46:36 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     netdev@...r.kernel.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, Petko Manolov <petkan@...leusys.com>
Subject: Re: [PATCH net 1/2] net: usb: pegasus: Check the return value of
 get_geristers() and friends;

On 8/3/21 6:45 PM, Petko Manolov wrote:
> On 21-08-03 18:28:55, Pavel Skripkin wrote:
>> On 8/3/21 6:03 PM, Petko Manolov wrote:
>> > From: Petko Manolov <petkan@...leusys.com>
>> > 
>> > Certain call sites of get_geristers() did not do proper error handling.  This
>> > could be a problem as get_geristers() typically return the data via pointer to a
>> > buffer.  If an error occured the code is carelessly manipulating the wrong data.
>> > 
>> > Signed-off-by: Petko Manolov <petkan@...leusys.com>
>> 
>> Hi, Petko!
>> 
>> This patch looks good to me, but I found few small mistakes
> 
> Yeah, the patch was never compiled.  Sorry about it.  v2 is coming up.
> 

BTW: should this also go to stable with Fixes: 1da177e4c3f4 
("Linux-2.6.12-rc2")?


With regards,
Pavel Skripkin