netdev - Re: [PATCH net v3 1/2] net: usb: pegasus: Check the return value of get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210803204946.38978b72@gmail.com>
Date:   Tue, 3 Aug 2021 20:49:46 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Petko Manolov <petko.manolov@...sulko.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, stable@...r.kernel.org,
        Petko Manolov <petkan@...leusys.com>
Subject: Re: [PATCH net v3 1/2] net: usb: pegasus: Check the return value of
 get_geristers() and friends;

On Tue,  3 Aug 2021 20:25:23 +0300
Petko Manolov <petko.manolov@...sulko.com> wrote:

> From: Petko Manolov <petkan@...leusys.com>
> 
> Certain call sites of get_geristers() did not do proper error
> handling.  This could be a problem as get_geristers() typically
> return the data via pointer to a buffer.  If an error occurred the
> code is carelessly manipulating the wrong data.
> 
> Signed-off-by: Petko Manolov <petkan@...leusys.com>
> ---
>  drivers/net/usb/pegasus.c | 108
> ++++++++++++++++++++++++++------------ 1 file changed, 75
> insertions(+), 33 deletions(-)
> 

All's good! Thank you :)

Reviewed-by: Pavel Skripkin <paskripkin@...il.com>


With regards,
Pavel Skripkin