lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 3 Aug 2021 11:11:16 -0700 (PDT)
From:   Mat Martineau <>
To:     Jakub Kicinski <>
cc:, Geliang Tang <>,,,
Subject: Re: [PATCH net] mptcp: drop unused rcu member in

On Tue, 3 Aug 2021, Jakub Kicinski wrote:

> On Mon,  2 Aug 2021 16:19:14 -0700 Mat Martineau wrote:
>> From: Geliang Tang <>
>> kfree_rcu() had been removed from pm_netlink.c, so this rcu field in
>> struct mptcp_pm_addr_entry became useless. Let's drop it.
>> Fixes: 1729cf186d8a ("mptcp: create the listening socket for new port")
>> Signed-off-by: Geliang Tang <>
>> Signed-off-by: Mat Martineau <>
> This just removes a superfluous member, right? So could as well be
> applied to net-next?

Hi Jakub -

Yes, it's just a superfluous member.

It seemed like a -net candidate, as it was addressing a mistake in a 
previous commit (rather than a feature or refactor) and does affect memory 
usage - and I was trying to be mindful of the stable tree process. But the 
patch will apply cleanly to either net or net-next, so you could apply to 
net-next if the fix is not significant enough.

I'll tune my net-vs-net-next threshold based on the tree I see it applied 
to :)


Mat Martineau

Powered by blists - more mailing lists