netdev - Re: [PATCH net-next 0/2] Convert switchdev_bridge_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210803181534.qgbcjow4ketd4yio@skbuf>
Date:   Tue, 3 Aug 2021 18:15:35 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Grygorii Strashko <grygorii.strashko@...com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ido Schimmel <idosch@...sch.org>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        "bridge@...ts.linux-foundation.org" 
        <bridge@...ts.linux-foundation.org>,
        Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH net-next 0/2] Convert switchdev_bridge_port_{,un}offload
 to notifiers

On Tue, Aug 03, 2021 at 08:11:56PM +0300, Grygorii Strashko wrote:
> I've tested builds, but was not able to test bridge itself on TI am57x platform.
> 
> 1) See warning
> [    3.958496] ------------[ cut here ]------------
> [    3.963165] WARNING: CPU: 0 PID: 1 at lib/refcount.c:25 fib_create_info+0xae8/0xbd4
> [    3.970855] refcount_t: addition on 0; use-after-free.
> [    3.976043] Modules linked in: autofs4
> [    3.979827] CPU: 0 PID: 1 Comm: systemd Not tainted 5.14.0-rc4-next-20210802-00002-g5003e4ac441d-dirty #5
> [    3.989440] Hardware name: Generic DRA72X (Flattened Device Tree)
> [    3.995574] [<c0111098>] (unwind_backtrace) from [<c010b834>] (show_stack+0x10/0x14)
> [    4.003356] [<c010b834>] (show_stack) from [<c09da808>] (dump_stack_lvl+0x40/0x4c)
> [    4.010986] [<c09da808>] (dump_stack_lvl) from [<c0137b44>] (__warn+0xd8/0x100)
> [    4.018341] [<c0137b44>] (__warn) from [<c09d6368>] (warn_slowpath_fmt+0x94/0xbc)
> [    4.025848] [<c09d6368>] (warn_slowpath_fmt) from [<c08f68d4>] (fib_create_info+0xae8/0xbd4)
> [    4.034332] [<c08f68d4>] (fib_create_info) from [<c08f99c4>] (fib_table_insert+0x5c/0x604¢·†AËÕìÍ_¡
> 
> 2) see warnings and "ip link add name br0 type bridge" just stuck
> [  158.032135] unregister_netdevice: waiting for lo to become free. Usage count = 3
> 
> It might not be related to this series.

100% not me.

See if you have David Ahern's bug fix, and if you do, try to see what
other refcount conversion patches Yajun Deng did, revert them one by one
and see if any one fixes the issue:
https://patchwork.kernel.org/project/netdevbpf/patch/20210802160221.27263-1-dsahern@kernel.org/