netdev - Re: [PATCH net-next v2 4/8] ravb: Add stats_len to struct ravb_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9c594b8-0353-6e24-54fa-de10171daeff@gmail.com>
Date:   Tue, 3 Aug 2021 22:20:26 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Biju Das <biju.das.jz@...renesas.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Sergey Shtylyov <s.shtylyov@...russia.ru>,
        Adam Ford <aford173@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Yuusuke Ashizuka <ashiduka@...itsu.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH net-next v2 4/8] ravb: Add stats_len to struct
 ravb_hw_info

On 8/3/21 9:47 PM, Biju Das wrote:

[...]
>>> R-Car provides 30 device stats, whereas RZ/G2L provides only 15. In
>>> addition, RZ/G2L has stats "rx_queue_0_csum_offload_errors" instead of
>>> "rx_queue_0_missed_errors".
>>>
>>> Replace RAVB_STATS_LEN macro with a structure variable stats_len to
>>> struct ravb_hw_info, to support subsequent SoCs without any code
>>> changes to the ravb_get_sset_count function.
>>>
>>> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
>>> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>> [...]
>>
>>    Finally a patch that I can agree with. :-)
>>
>> Reviewed-by: ergei Shtylyov <sergei.shtylyov@...il.com>
>               ^Typo here.

   Sorry, here's a good one:

Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...il.com>

> Cheers,
> Biju

MBR, Sergei