netdev - Re: [PATCH] net: pegasus: fix uninit-value in get_interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Aug 2021 07:36:57 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Pavel Skripkin <paskripkin@...il.com>, davem@...emloft.net,
        kuba@...nel.org, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot+02c9f70f3afae308464a@...kaller.appspotmail.com
Subject: Re: [PATCH] net: pegasus: fix uninit-value in get_interrupt_interval

On Mon, Aug 02, 2021 at 11:07:23PM +0300, Petko Manolov wrote:
> diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
> index 9a907182569c..eafbe8107907 100644
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -26,6 +26,8 @@
>   *		...
>   *		v0.9.3	simplified [get|set]_register(s), async update registers
>   *			logic revisited, receive skb_pool removed.
> + *		v1.0.1	add error checking for set_register(s)(), see if calling
> + *			get_registers() has failed and print a message accordingly.
>   */
>  
>  #include <linux/sched.h>
> @@ -45,7 +47,7 @@
>  /*
>   * Version Information
>   */
> -#define DRIVER_VERSION "v0.9.3 (2013/04/25)"
> +#define DRIVER_VERSION "v1.0.1 (2021/08/01)"

Nit, the log above, and the driver version here, mean nothing when it
comes to code in the kernel tree, both should be dropped as we have full
kernel changelog through git, and the version is bound to the kernel
release the driver came in.

thanks,

greg k-h