netdev - Re: [PATCH bpf-next v2] selftests/bpf: move netcnt test under test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzZZCzfywqLRK8Jodzf-XmRrKHRTsqGGE_erXdxm+coxqg@mail.gmail.com>
Date:   Mon, 2 Aug 2021 17:32:06 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Yonghong Song <yhs@...com>
Subject: Re: [PATCH bpf-next v2] selftests/bpf: move netcnt test under test_progs

On Mon, Aug 2, 2021 at 10:39 AM Stanislav Fomichev <sdf@...gle.com> wrote:
>
> Rewrite to skel and ASSERT macros as well while we are at it.
>
> v2:
> - don't check result of bpf_map__fd (Yonghong Song)
> - remove from .gitignore (Andrii Nakryiko)
> - move ping_command into network_helpers (Andrii Nakryiko)
> - remove assert() (Andrii Nakryiko)
>
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> Acked-by: Yonghong Song <yhs@...com>
> ---

netcnt selftest is failing in our CI ([0]), PTAL. xdp_context_test_run
failure is unrelated, ignore that one.

  [0] https://github.com/kernel-patches/bpf/runs/3225481504?check_suite_focus=true

>  tools/testing/selftests/bpf/.gitignore        |   1 -
>  tools/testing/selftests/bpf/Makefile          |   3 +-
>  tools/testing/selftests/bpf/network_helpers.c |  12 ++
>  tools/testing/selftests/bpf/network_helpers.h |   1 +
>  .../testing/selftests/bpf/prog_tests/netcnt.c |  82 ++++++++++
>  .../selftests/bpf/prog_tests/tc_redirect.c    |  12 --
>  tools/testing/selftests/bpf/test_netcnt.c     | 148 ------------------
>  7 files changed, 96 insertions(+), 163 deletions(-)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/netcnt.c
>  delete mode 100644 tools/testing/selftests/bpf/test_netcnt.c
>

[...]