netdev - Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMjFOPFfU4ibFJPYdYUSh0nFkRwfW1cdAV2BMvg1aaP_eg@mail.gmail.com>
Date:   Wed, 4 Aug 2021 16:26:31 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Christoph Hellwig <hch@....de>, Jakub Kicinski <kuba@...nel.org>
Cc:     Boris Pismenny <borisp@...dia.com>,
        David Miller <davem@...emloft.net>,
        Saeed Mahameed <saeedm@...dia.com>,
        Sagi Grimberg <sagi@...mberg.me>, axboe@...com,
        Keith Busch <kbusch@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Eric Dumazet <edumazet@...gle.com>,
        Shai Malin <smalin@...vell.com>, boris.pismenny@...il.com,
        linux-nvme@...ts.infradead.org,
        Linux Netdev List <netdev@...r.kernel.org>,
        benishay@...dia.com, Or Gerlitz <ogerlitz@...dia.com>,
        Yoray Zack <yorayz@...dia.com>, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for_sock

On Fri, Jul 23, 2021 at 9:09 AM Christoph Hellwig <hch@....de> wrote:
>
> On Thu, Jul 22, 2021 at 02:02:53PM +0300, Boris Pismenny wrote:
> > From: Boris Pismenny <borisp@...lanox.com>
> >
> > get_netdev_for_sock is a utility that is used to obtain
> > the net_device structure from a connected socket.
> >
> > Later patches will use this for nvme-tcp DDP and DDP DDGST offloads.
> >
> > Signed-off-by: Boris Pismenny <borisp@...lanox.com>
> > Reviewed-by: Sagi Grimberg <sagi@...mberg.me>
>
> I don't think this should be an inline.  Please move it to net/core/dev.c,
> andd add an EXPORT_SYMBOL_GPL and a kerneldoc comment.

Jakub,

What's your preference here?

Or.