netdev - Re: [PATCH net-next v2] net: Modify sock_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQop+GhJcKICdwZ0@unreal>
Date:   Wed, 4 Aug 2021 08:47:36 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Yajun Deng <yajun.deng@...ux.dev>
Cc:     davem@...emloft.net, kuba@...nel.org,
        mathew.j.martineau@...ux.intel.com, matthieu.baerts@...sares.net,
        trond.myklebust@...merspace.com, anna.schumaker@...app.com,
        cluster-devel@...hat.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org, mptcp@...ts.linux.dev,
        linux-rdma@...r.kernel.org, rds-devel@....oracle.com,
        linux-s390@...r.kernel.org, linux-nfs@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: Modify sock_set_keepalive() for more
 scenarios

On Wed, Aug 04, 2021 at 11:28:56AM +0800, Yajun Deng wrote:
> Add 2nd parameter in sock_set_keepalive(), let the caller decide
> whether to set. This can be applied to more scenarios.
> 
> v2:
>  - add the change in fs/dlm.
> 
> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> ---
>  fs/dlm/lowcomms.c     |  2 +-
>  include/net/sock.h    |  2 +-
>  net/core/filter.c     |  4 +---
>  net/core/sock.c       | 10 ++++------
>  net/mptcp/sockopt.c   |  4 +---
>  net/rds/tcp_listen.c  |  2 +-
>  net/smc/af_smc.c      |  2 +-
>  net/sunrpc/xprtsock.c |  2 +-
>  8 files changed, 11 insertions(+), 17 deletions(-)

1. Don't add changelogs in the commit messages and put them under --- marker.
2. Add an explanation to the commit message WHY this change is necessary
and HOW will it be used.
3. Drop all your double NOT in front of values (!!val) and rely on C
that casts int to bool naturally.

Thanks