netdev - Re: [PATCH net-next] Revert "netdevsim: Add multi-queue support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQo+XJQNAP7jnGw0@unreal>
Date:   Wed, 4 Aug 2021 10:14:36 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Cong Wang <xiyou.wangcong@...il.com>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "Cong Wang ." <cong.wang@...edance.com>,
        Peilin Ye <peilin.ye@...edance.com>
Subject: Re: [PATCH net-next] Revert "netdevsim: Add multi-queue support"

On Tue, Aug 03, 2021 at 02:51:24PM -0700, Jakub Kicinski wrote:
> On Tue, 3 Aug 2021 14:32:19 -0700 Cong Wang wrote:
> > On Tue, Aug 3, 2021 at 2:18 PM Jakub Kicinski <kuba@...nel.org> wrote:

<...>

> > Please remove all those not covered by upstream tests just to be fair??
> 
> I'd love to remove all test harnesses upstream which are not used by
> upstream tests, sure :)

Jakub,

Something related and unrelated at the same time.

I need to get rid of devlink_reload_enable()/_disable() to fix some
panics in the devlink reload flow.

Such change is relatively easy for the HW drivers, but not so for the
netdevism due to attempt to synchronize sysfs with devlink.

  200         mutex_lock(&nsim_bus_dev->nsim_bus_reload_lock);
  201         devlink_reload_disable(devlink);
  202         ret = nsim_dev_port_add(nsim_bus_dev, NSIM_DEV_PORT_TYPE_PF, port_index);
  203         devlink_reload_enable(devlink);
  204         mutex_unlock(&nsim_bus_dev->nsim_bus_reload_lock);

Are these sysfs files declared as UAPI? Or can I update upstream test
suite and delete them safely?

Thanks