netdev - Re: [Intel-wired-lan] [PATCH v2] igc: fix page fault when thunderbolt is unplugged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <567b12f8-359a-5268-e020-edcf2dd46937@linux.intel.com>
Date:   Wed, 4 Aug 2021 15:06:44 +0300
From:   "Fuxbrumer, Dvora" <dvorax.fuxbrumer@...ux.intel.com>
To:     Aaron Ma <aaron.ma@...onical.com>, jesse.brandeburg@...el.com,
        anthony.l.nguyen@...el.com, davem@...emloft.net, kuba@...nel.org,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH v2] igc: fix page fault when thunderbolt
 is unplugged

On 7/13/2021 16:00, Aaron Ma wrote:
> After unplug thunerbolt dock with i225, pciehp interrupt is triggered,
> remove call will read/write mmio address which is already disconnected,
> then cause page fault and make system hang.
> 
> Check PCI state to remove device safely.
> 
> Trace:
> BUG: unable to handle page fault for address: 000000000000b604
> Oops: 0000 [#1] SMP NOPTI
> RIP: 0010:igc_rd32+0x1c/0x90 [igc]
> Call Trace:
> igc_ptp_suspend+0x6c/0xa0 [igc]
> igc_ptp_stop+0x12/0x50 [igc]
> igc_remove+0x7f/0x1c0 [igc]
> pci_device_remove+0x3e/0xb0
> __device_release_driver+0x181/0x240
> 
> Signed-off-by: Aaron Ma <aaron.ma@...onical.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 32 ++++++++++++++---------
>   drivers/net/ethernet/intel/igc/igc_ptp.c  |  3 ++-
>   2 files changed, 21 insertions(+), 14 deletions(-)
> 
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@...ux.intel.com>