netdev - Re: [PATCH net-next v4] ethernet: fix PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Aug 2021 16:10:17 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Richard Cochran <richardcochran@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Shannon Nelson <snelson@...sando.io>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        Tariq Toukan <tariqt@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        Jiri Pirko <jiri@...dia.com>, Ido Schimmel <idosch@...dia.com>,
        drivers@...sando.io, Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Edward Cree <ecree.xilinx@...il.com>,
        Martin Habets <habetsm.xilinx@...il.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Yangbo Lu <yangbo.lu@....com>, Karen Xie <kxie@...lsio.com>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH net-next v4] ethernet: fix PTP_1588_CLOCK dependencies

On Thu, Aug 5, 2021 at 3:32 PM Vladimir Oltean <olteanv@...il.com> wrote:
> >
> >  # Users should depend on NET_SWITCHDEV, HAS_IOMEM, BRIDGE
> >  config MSCC_OCELOT_SWITCH_LIB
> > +     depends on PTP_1588_CLOCK_OPTIONAL
>
> No, don't make the MSCC_OCELOT_SWITCH_LIB depend on anything please,
> since it is always "select"-ed, it shouldn't have dependencies, see
> the comment above. If you want, add this to the comment: "Users should
> depend on (...), PTP_1588_CLOCK_OPTIONAL".
>

Changed now, but I only saw your message after I had already sent out v5 of
the patch. I'll hold off on sending v6 for the moment, in case someone else
notices something odd.

I generally prefer having the extra dependencies like this, because it documents
what the requirement is, and causes a config-time warning before the kernel
runs into a link failure when someone else gets the dependency wrong later.
I don't feel too strongly about it though, and I don't expect adding a comment
would help much either here, so I'm leaving it without that line.

       Arnd